fix(repository): validate configured remotes before cache access (BUG-001) - #296
fix(repository): validate configured remotes before cache access (BUG-001)#296sbalabanov wants to merge 1 commit into
Conversation
|
|
324af87 to
bcbfc86
Compare
bcbfc86 to
f13fc1e
Compare
sbalabanov
changed the title
sbalabanov
changed the title
|
make a PR description relevant to the diff between the latest change and a base revision. Simplify wording. Include use case example showing the bug. |
f13fc1e to
2f5946b
Compare
|
Updated the PR description for the current diff in 2f5946b. It now uses simpler wording and includes a concrete example where GitHub and GitLab remotes with the same repository path previously collided in cache and workspace namespaces. [addressed by agent] |
|
Updated the PR description for the current diff against main and added a concrete BUG-001 example showing an unconfigured relative remote being rejected before cache or workspace access. Final SHA: 2f5946b. [addressed by agent] |
Resolve BUG-001 without canonicalizing client-provided repository values. - require exact configured remote matches before controller cache reads - hash exact configured values for cache, workspace, and metric identities - reject credential-bearing and ambiguous repository URL configuration - retain clone-root containment checks - remove the unrelated Bazel timeout change
2f5946b to
d3578e8
Compare
3 participants
Summary
Validate repository remotes before they can select cache or workspace state.
BUG-001 example
If Tango is configured for
git@github.com:uber/tango.gitbut a request supplies an unconfigured value such as../../outside, the old flow could derive cache or workspace identifiers from the request before confirming it was configured. The new flow rejects that request as an unknown repository before cache access; only the exact configured remote can reach repository state.Test Plan
go test -count=1 ./config ./internal/url ./core/repomanager ./core/cachekey ./controller ./orchestrator/..../tools/bazel test //config:config_test //internal/url:url_test //core/repomanager:repomanager_test //core/cachekey:cachekey_test //controller:controller_test //orchestrator:orchestrator_test --nocache_test_results --test_output=errorsRevert Plan
Revert the commit.
Issues
T3-BUG-001